Skip to content

ApplicationState Enhancements - Documentation #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 1, 2024
Merged

ApplicationState Enhancements - Documentation #2269

merged 24 commits into from
Aug 1, 2024

Conversation

@majedelass
Copy link
Contributor

@majedelass majedelass commented Jul 23, 2024 •
edited by atlassian bot
Loading

📌 Summary

If merged, this PR will update the documentation for the ApplicationState component.

🛠️ Detailed description

Outlining all the enhancements coming to the component such as alignment, media and a more flexible footer with additional CTA types (like button and dropdown).

🔗 External links

Jira ticket: HDS-3543
Figma file: Link

👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 1, 2024 4:37pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 1, 2024 4:37pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jul 23, 2024
@majedelass majedelass requested review from a team July 23, 2024 22:18
zamoore
zamoore reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good so far!

@majedelass majedelass closed this Jul 24, 2024
@didoo didoo reopened this Jul 24, 2024
@majedelass majedelass marked this pull request as draft July 24, 2024 12:20
@zamoore zamoore force-pushed the application-state-docs-enhancements branch from 68c9871 to f37877e Compare July 24, 2024 19:28
@zamoore zamoore changed the base branch from main to FEATURE-HDS-3542-ApplicationState-Code July 24, 2024 19:29
majedelass and others added 12 commits August 1, 2024 10:23
@majedelass @zamoore
Updated image to not wrap
c0a3933
@majedelass @zamoore
Added image showing the three types of actions in the footer
9ccc86c
@majedelass @zamoore
Updated order of list to follow suit with the image
98c1442
@majedelass @zamoore
updated images to match padding standards established yesterday
fc1e63f
@zamoore
updated engineering docs
881de01
@majedelass @KristinLBradley @zamoore
Update website/docs/components/application-state/partials/guidelines/…
69bd107 
…guidelines.md

Co-authored-by: Kristin Bradley <[email protected]>
@majedelass @jorytindall
@KristinLBradley @zamoore
Apply suggestions from code review
d2c88d0 
Co-authored-by: Jory Tindall <[email protected]>
Co-authored-by: Kristin Bradley <[email protected]>
@majedelass @zamoore
Update website/docs/components/application-state/partials/guidelines/…
742a268 
…guidelines.md


Adding new line
@majedelass @zamoore
Updated footer phrasing to match Jory's suggestion
17ca661
@zamoore
addressing PR feedback
071bcd7
@didoo @zamoore
updated the “Component API” section
8af9007
@majedelass @didoo @zamoore
Apply suggestions from code review
7387021 
Co-authored-by: Cristiano Rastelli <[email protected]>
@zamoore zamoore force-pushed the application-state-docs-enhancements branch from 59ede49 to 7387021 Compare August 1, 2024 14:24
didoo
didoo approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so it won't block the release

@majedelass majedelass requested a review from jorytindall August 1, 2024 17:37
jorytindall
jorytindall approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zamoore zamoore merged commit 57046dd into FEATURE-HDS-3542-ApplicationState-Code Aug 1, 2024
@zamoore zamoore deleted the application-state-docs-enhancements branch August 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zamoore zamoore zamoore left review comments

@didoo didoo didoo approved these changes

@jorytindall jorytindall jorytindall approved these changes

@KristinLBradley KristinLBradley KristinLBradley approved these changes

@MelSumner MelSumner Awaiting requested review from MelSumner

Assignees

@zamoore zamoore

@majedelass majedelass

Labels

docs-website Content updates to the documentation website showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@majedelass @didoo @jorytindall @MelSumner @zamoore @KristinLBradley @hashibot-hds